-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Mangaung & NMB areas #454
base: main
Are you sure you want to change the base?
Conversation
Script to generate all of Nelson Mandella Bay Groups
Corrected times
New files for NMB
Hi there, I need to know the source of your information for the changed areas as previously mentioned. I see you said this URL was for mangaung: But please also provide a URL for NMB. |
Hi there, apologies for the long delay, I had to focus on some personal things for a while. For the Mangaung changes, all looks good. I'm happy to merge them in, although there are some issues with the NMB schedules (see below). If you open up a new PR with just the Mangaung changes then I'll merge that PR. Thanks! The NMB schedules are no longer up-to-date because NMB has updated their schedules (the latest one looks like it covers 4 September 2023 - 3 December 2023). It's not feasible for me to re-calculate the schedules every couple of months, so a NMB schedule would have to be resilient to this sort of change. The main codebase supports a different format for the CSVs which could help with this. Instead of specifying the date of the month, you can specify a periodic schedule that has an arbitrary start and arbitrary repetition frequency. For example, to specify a schedule that repeats every 19 days and started on the 15th September 2023:
(whitespace added for clarity) As per the updated schedule for NMB: If the NMB schedules are specified in this way, I think they won't need to be updated every 3 months because the new schedules announced by NMB would match the ones predicted by the periodic schedule. |
Ok, I have started over again. Understand GitHub better now. These are the proposed changes